Skip to content

test: check napi_get_reference_value() during finalization #27470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: check napi_get_reference_value() during finalization #27470

wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added test Issues and PRs related to the tests. node-api Issues and PRs related to the Node-API. labels Apr 29, 2019
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3386

@addaleax addaleax mentioned this pull request Apr 29, 2019
Closed
cjihrig
cjihrig approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this file uses NAPI_ASSERT(). Maybe this change should as well, for consistency? No big deal either way though.

@addaleax
Copy link
Member Author

@cjihrig NAPI_ASSERT() throws a JS error, which isn’t possible here – it’s just unfortunate naming…

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22809/

@Trott
Copy link
Member

Trott commented May 1, 2019

Landed in e1c838e

@Trott Trott closed this May 1, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 1, 2019
@addaleax @Trott
test: check napi_get_reference_value() during finalization
e1c838e 
PR-URL: nodejs#27470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 4, 2019
@addaleax @targos
test: check napi_get_reference_value() during finalization
a9a85d6 
PR-URL: #27470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax @nodejs-github-bot @Trott @cjihrig